-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
important feature CALLING Country Code #8
Comments
I suppose REST Countries would be a better fit, but, @peric , here's an issue: should we change the Here are two points:
What's your opinion? |
@toubou91, cool ideas... At the moment, I'm still rewriting current application to use react.js (#24). I got stuck a bit because of other obligations but I think I'll finish this sometimes this week. Sometimes after that, we can maybe do additional refactoring and use REST countries instead of Geonames, I would just need to check whether all the existing fields can be fetched from there. So, let's talk after I finish #24 and merge it to master |
+1, maybe no.1 is better |
Ok, I see that a full refactoring sounds better, to both of you. Ok @peric, take your time and we 'll talk again soon (, as I have written down some points that need to be clarified, if you finally go for the REST Countries). Good luck! |
Maybe this is an interesting subject for you again? Now when the "rectification" is done. |
thank you for the amasing work you have done,
can you plz add the CALLING Country Code
like lebanon 961
you can grab them from this site
http://countrycode.org/
The text was updated successfully, but these errors were encountered: