Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

important feature CALLING Country Code #8

Open
syrakozz opened this issue Oct 8, 2014 · 5 comments
Open

important feature CALLING Country Code #8

syrakozz opened this issue Oct 8, 2014 · 5 comments

Comments

@syrakozz
Copy link

syrakozz commented Oct 8, 2014

thank you for the amasing work you have done,
can you plz add the CALLING Country Code
like lebanon 961
you can grab them from this site
http://countrycode.org/

@teobais
Copy link
Contributor

teobais commented May 23, 2015

I suppose REST Countries would be a better fit, but, @peric , here's an issue:

should we change the GetCountries project, in order to completely consume the API that I fore-mentioned, or would you like to adjust the call to the geonames API, to the current need?

Here are two points:

  1. The first one will make the feature that this issue refers to, easier, but requires enough modifications in the current source, I guess.
  2. The second option leaves the current source as is, but has to cleverly combine it with the required "calling country code" fetching from the external API; this also means that we will have two calls to external services.

What's your opinion?

@peric
Copy link
Owner

peric commented May 25, 2015

@toubou91, cool ideas...

At the moment, I'm still rewriting current application to use react.js (#24). I got stuck a bit because of other obligations but I think I'll finish this sometimes this week.

Sometimes after that, we can maybe do additional refactoring and use REST countries instead of Geonames, I would just need to check whether all the existing fields can be fetched from there.

So, let's talk after I finish #24 and merge it to master

@syrakozz
Copy link
Author

+1, maybe no.1 is better

@teobais
Copy link
Contributor

teobais commented May 26, 2015

Ok, I see that a full refactoring sounds better, to both of you.

Ok @peric, take your time and we 'll talk again soon (, as I have written down some points that need to be clarified, if you finally go for the REST Countries).

Good luck!

@peric
Copy link
Owner

peric commented Nov 10, 2015

Maybe this is an interesting subject for you again? Now when the "rectification" is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants