Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a user to specify the image [source] and the tag for en existing userenv #517

Open
atheurer opened this issue Jul 17, 2024 · 3 comments
Assignees
Labels

Comments

@atheurer
Copy link
Contributor

Userenvs have predefined values for image and tag, for example:

  "userenv": {
    "name": "rhel-ai",
    "label": "RHEL AI",
    "origin": {
      "image": "quay.io/kvalin/instructlab-training",
      "tag": "latest-jul10"
    },

Users need the ability to substitute a different image and tag.
As this applies to remotehosts endpoints, the proposed interface is:

{
  {
  "tags": {
    "topology": "none"
  },
  "endpoints": [
    {
      "type": "remotehosts",
      "remotes": [
        {
          "engines": [ { "role": "client", "ids": "1" } ],
          "config": {
            "host": "localhost",
            "settings": {
              "controller-ip-address": "10.26.8.21",
              "userenv": "rhel-ai",
              "userenv-settings": {
                "image": "quay.io/project/container",
                "tag": "fullofbugs"
              },
              "osruntime": "podman",
              "cpu-partitioning": false
            }
          }
        }
      ]
    }
  ]
}
@k-rister k-rister moved this from Queued to Todo in Crucible Tracking Aug 5, 2024
@k-rister k-rister self-assigned this Aug 6, 2024
@atheurer
Copy link
Contributor Author

atheurer commented Sep 4, 2024

@k-rister I am wondering if this should also include an "auth" section as well, which points to an auth file, or we should try to get the rickshaw container [that uses workshop] to get any container auths already created on the host (/run/user/0/containers/auth.json), so any of the user's podman login on the host would be valid for crucible as well.

@k-rister
Copy link
Contributor

k-rister commented Sep 4, 2024

@k-rister I am wondering if this should also include an "auth" section as well, which points to an auth file, or we should try to get the rickshaw container [that uses workshop] to get any container auths already created on the host (/run/user/0/containers/auth.json), so any of the user's podman login on the host would be valid for crucible as well.

My idea was to match the origin image property against the URL from the array of userenvs in https://github.com/perftool-incubator/crucible/blob/master/spec/registries.json.md in order to find the appropriate token.

@atheurer
Copy link
Contributor Author

atheurer commented Sep 5, 2024

OK, I think that will work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Todo
Development

No branches or pull requests

2 participants