From f90a1d79fdab252f527b2631a2001361a4a79ce7 Mon Sep 17 00:00:00 2001
From: Rafael Folco <rfolco@redhat.com>
Date: Wed, 23 Oct 2024 08:35:39 -0400
Subject: [PATCH] [bugfix] Change Bash regex for engine labels

It is now capable of capturing a profiler name with dashes in the
middle of the string - e.g. rt-trace-bpf.
---
 engine/engine-script-library | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/engine/engine-script-library b/engine/engine-script-library
index d0e6f790..0918b1f3 100644
--- a/engine/engine-script-library
+++ b/engine/engine-script-library
@@ -305,14 +305,20 @@ function validate_core_env() {
     if [ -z "$cs_label" ]; then
         exit_error "The client/server label (--cs-label) was not defined"
     fi
-    # profiler-remotehost-1-sysstat-1
-    regex1='^profiler-\w+-\d+-\w+-\d+$'
-    # client-1
-    regex2='^\w+-\d+$'
-    if echo $cs_label | grep -q -P $regex1; then
-        export tool_name=`echo $cs_label | awk -F- '{print $4}'`
+    # (rfolco): regex 101
+    #     ^profiler- ensures the string starts with profiler-.
+    #     ([a-zA-Z]+) captures one or more lowercase/uppercase letters for the second part.
+    #     ([0-9]+) captures one or more digits for the third part.
+    #     ([a-zA-Z_-]+) captures one or more lowercase/uppercase letters, underscores, or dashes for the fourth part.
+    #     ([0-9]+)$ ensures the string ends with a number after the last part.
+    #     e.g. profiler-remotehost-1-sysstat-1 or profiler-remotehost-1-rt-trace-bpf-1
+    regex1='^profiler-([a-zA-Z]+)-([0-9]+)-([a-zA-Z_-]+)-([0-9]+)$'
+    # client-1 or server-1
+    regex2='^([a-zA-Z]+)-([0-9]+)$'
+    if [[ $cs_label =~ $regex1 ]]; then
+	export tool_name=`echo $cs_label | sed -E 's/^[^-]+-[^-]+-[0-9]+-(.+)-[0-9]+$/\1/'`
         echo "engine-label \"$cs_label\" is valid and runs this tool:  $tool_name"
-    elif echo $cs_label | grep -q -P $regex2; then
+    elif [[ $cs_label =~ $regex2 ]]; then
         echo "engine-label \"$cs_label\" is valid"
     else
         exit_error 'cs_label "'$cs_label'" is not valid'