Update PlacesDetailPanel with more flexible styling #264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dleadbetter
reviewed
Mar 11, 2024
There was a problem hiding this comment.
Looks good! (And was a much simpler change than I was anticipating). I think it's probably fine that this is a breaking change, as I don't believe any projects are currently using these components.
Could we add an example of using the component as a Sidebar using Tailwind instead of Semantic UI? This will likely involve adding Tailwind to the storybook package, but I think that most projects using these components will be using Tailwind, so it will probably be good to have examples.
…ort for multiple geometries; Adding "core_data" middleware
…on_markers RC #261 - Location markers
…-software/react-components into RB-place-detail-modal
|
Added some Tailwind examples to the Storybook page. @dleadbetter |
|
Closing and reopening to try to get GitHub to update the file diffs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR
core-data/PlacesDetailPanelcomponent to remove the absolute positioning and fixed width;semantic-ui-reactSidebarcomponent andModalcomponentNotes
Unsure about the best way to structure this change; as is, it's sort of a breaking change in that existing uses of the panel as a sidebar specifically will need to be updated to actually wrap the component in a sidebar other custom styled component to recover the same behavior. Alternatively we could force backward compatibility by passing some sort of optional
modalflag as a prop and only apply the updated CSS if that flag is applied, but that seems significantly less elegant. Open to thoughts!