Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump for cypress 3.2.0 #62

Closed
Pomax opened this issue Mar 20, 2019 · 4 comments
Closed

bump for cypress 3.2.0 #62

Pomax opened this issue Mar 20, 2019 · 4 comments

Comments

@Pomax
Copy link

Pomax commented Mar 20, 2019

Cypress got updated to 3.2.0, so it might be worth explicitly updating the dependency in package.json and then running an npm patch release.

@Robdel12
Copy link
Contributor

Hey there! When I was doing some testing with the latest cypress I ran into a lot of issues with domains: cypress-io/cypress#3717 So I'd be a little wary locking to that version.

Also, we specify "^3.1.3" which will grab the latest patch version (3.2.0 in this case)

I believe it should update in your project if you install 3.2.0 (and had an older version previously)

@Pomax
Copy link
Author

Pomax commented Mar 20, 2019

it does, but npm's had a ton of fun gaffs the last year or so, so at this point a good package-lock.json is a locked down package-lock.json that absolutely never respects ^ and just pulls the exact version so it's on a known good version =)

That said, it sounds like 3.2.0 is not a good version =(

@Robdel12
Copy link
Contributor

Ah, yeah, I hear you there! I usually run npm update @percy/cypress (or yarn upgrade @percy/cypress) to update the lockfiles

@djones
Copy link
Contributor

djones commented Apr 9, 2019

Closing this one since our package-lock.json file has resolved to version [email protected].

We usually bump the version requirements in the package.json if a particular version of @percy/cypress requires a higher version of a dependency. This #80 is a good example of that.

@djones djones closed this as completed Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants