Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Percy on Automate: Check if deviceName was passed #1370

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Percy on Automate: Check if deviceName was passed #1370

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1209084
Check if deviceName was passed
Amit3200 Sep 13, 2023
9eda3e4
Updating Tests
Amit3200 Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/webdriver-utils/src/metadata/metaDataResolver.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,8 @@ export default class MetaDataResolver {
const platform = opts.platformName || opts.platform;
if (['ios', 'android'].includes(platform.toLowerCase()) ||
['ios', 'android'].includes(capabilities?.platformName?.toLowerCase()) ||
['ipad', 'iphone'].includes(capabilities?.device?.toString()?.toLowerCase())) {
['ipad', 'iphone'].includes(capabilities?.device?.toString()?.toLowerCase()) ||
itsjwala marked this conversation as resolved.
Show resolved Hide resolved
opts?.deviceName !== undefined) {
return new MobileMetaData(driver, capabilities);
} else {
return new DesktopMetaData(driver, capabilities);
Expand Down
Loading