This repository has been archived by the owner on Aug 24, 2022. It is now read-only.
PMM-9377 add compatibility with updated pmm #323
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idoqo
force-pushed
the
PMM-9377-update-grpc-gateway
branch
3 times, most recently
from
ace469b to
f91ae1a
Compare
3 tasks
2 tasks
idoqo
requested review from
artemgavrilov,
JiriCtvrtka,
palash25 and
PavelKhripkov
3 tasks
BupycHuk
approved these changes
Mar 13, 2022
idoqo
force-pushed
the
PMM-9377-update-grpc-gateway
branch
from
919d316 to
5ec6530
Compare
BupycHuk
reviewed
Mar 14, 2022
Comment on lines
-88
to
+90
| if errors.Is(err, e) { | ||
| if strings.Contains(err.Error(), e.Error()) { |
There was a problem hiding this comment.
please add a comment why it's changed
There was a problem hiding this comment.
Some errors contain variable data (e.g connection closed errors include the server IP and port), and those changes between environments so I think it makes sense to check for the relevant substring, as the complete error is not likely to be the same.
you think it should be a code comment?
There was a problem hiding this comment.
yeah, let's make it a code comment
|
LGTM, please add comment where Nurlan wanted it. |
JiriCtvrtka
approved these changes
Mar 15, 2022
3 tasks
idoqo
force-pushed
the
PMM-9377-update-grpc-gateway
branch
5 times, most recently
from
a9545df to
d5d98b6
Compare
idoqo
force-pushed
the
PMM-9377-update-grpc-gateway
branch
from
d5d98b6 to
f476e71
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PMM-9377
Build: SUBMODULES-2355