PMM-5194 Tunnels #141
PMM-5194 Tunnels #141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
==========================================
- Coverage 24.53% 24.19% -0.34%
==========================================
Files 47 48 +1
Lines 3212 3265 +53
==========================================
+ Hits 788 790 +2
- Misses 2399 2450 +51
Partials 25 25
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
commands/inventory/list_tunnels.go
Outdated
| }, "\t") | ||
| fmt.Fprintln(w, line) | ||
| } | ||
| w.Flush() |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
Error return value of w.Flush is not checked (errcheck)
| "github.com/percona/pmm-admin/commands" | ||
| ) | ||
|
|
||
| type listResultTunnel struct { |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
struct of size 64 bytes could be of size 56 bytes (maligned)
| } | ||
|
|
||
| func (cmd *listTunnelsCommand) Run() (commands.Result, error) { | ||
| params := &tunnels.ListTunnelsParams{ |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
HTTPClient is missing in ListTunnelsParams (exhaustivestruct)
| ListenPort uint16 `json:"listen_port"` | ||
| } | ||
|
|
||
| type TunnelStatus struct { |
There was a problem hiding this comment.
🚫 [golangci-lint] reported by reviewdog 🐶
exported type TunnelStatus should have comment or be unexported (golint)
No description provided.