PBM-1310 Release notes 2.5.0 #176
Conversation
|
Your Render PR Server URL is https://pbm-docs-pr-176.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cotmiro21fec73b5vn10. |
docs/release-notes/2.5.0.md
Outdated
| ## Release Highlights | ||
|
|
||
| * You can now restore the desired subset of [custom databases with users and roles](../features/selective-backup.md#restore-a-database-with-users-and-roles) created in them. This is useful for deployments where each user has an individual database and authenticates against it. | ||
| * By design, PBM requires the majority level of readConcern and writeConcern in MongoDB. If your cluster is configured to operate without the majority or loses it for some reason, you can now override readConcern and writeConcern to use PBM with your cluster for backups. |
There was a problem hiding this comment.
Instead I would say:
Previous versions of PBM required that readConcern and writeConcern levels are set to majority in MongoDB. You can now explicitly override this behaviour, which allows backing up Primary-Secondary-Arbiter topologies that run with writeConcern majority disabled.
There was a problem hiding this comment.
I believe this requirement is still valid. @boris-ilijic @sandraromanchenko please confirm
There was a problem hiding this comment.
I am fine to have this in the release highlights, 1st sentence for sure, but 2nd one is not completely clear for me:
'…Primary-Secondary-Arbiter topologies that run with writeConcern majority disabled'
So to be sure that we were testing everything and that we are referring to the same thing, I can think that you are referring here to:
- PSA with failed S (no majority because of failing member)
- PSA with non-voting S (majority is 1)
- PSA with lagging S (majority cannot be reached in 'normal' execution time)
@igroene did you refer to this configurations or to something else/more ?
If yes, for me it'll be clearer to say: '…Primary-Secondary-Arbiter topologies that run without write majority'
BTW, there are other topologies in which 'lowering' R/W/Concern can be beneficial, so it's not just PSA, and such one is described in: PBM-799 description. But probably we do not need to mention that in highlights.
There was a problem hiding this comment.
Sorry I meant to say here "read concern majority disabled". This is related to https://www.mongodb.com/docs/v3.6/reference/read-concern-majority/#disable-read-concern-majority
There was a problem hiding this comment.
Yes, but that option is obsolete in Mongo4.x and in Mongo5 and above is not configurable anymore: https://www.mongodb.com/docs/manual/release-notes/5.0-compatibility/#enablemajorityreadconcern-is-not-configurable.
Also we double checked that option with customer, please see this thread for details: https://perconadev.atlassian.net/browse/PBM-1159?focusedCommentId=409702
In that case I strongly recommend to not mention that use case in highlights, even more because we didn't test it, because Mongo4.x is EOL. My recommendation is to take 1st Ivan's / 2nd Anastasia'a sentences then.
There was a problem hiding this comment.
we still have customers running 4.x and PSA topologies, and that is actually the reason why we are implementing this change to allow them to still use PBM. So why would we not mention it in the release notes?
There was a problem hiding this comment.
My point was to not mention use case with explicit obsolete option (--enableMajorityReadConcern). But if that's important for us I do not have concerns. We'll do additional testing on Monday on Mongo4.2 with disabled that option, but imo that should work.
There was a problem hiding this comment.
It works just fine with ReadConcern majority disabled on DB level (PSMDB 4.4)
pbm-agent --mongodb-uri="mongodb://XXX:XXX@testdb:27017/?authSource=admin"
Version: 2.5.0
Platform: linux/amd64
GitCommit: be273eee454fbbb2bd269bb46c24078b35d98894
GitBranch: release-2.5.0
BuildTime: 2024-05-15_05:58_UTC
GoVersion: go1.22.3
2024-05-15T05:56:29.000+0000 I starting PITR routine
2024-05-15T05:56:29.000+0000 I node: rs1/testdb:27017
2024-05-15T05:56:29.000+0000 E [pitr] init: get conf: get: (ReadConcernMajorityNotEnabled) Majority read concern is not enabled.
2024-05-15T05:56:29.000+0000 I listening for the commands
2024-05-15T05:56:29.000+0000 E listening commands: watch the cmd stream: (ReadConcernMajorityNotEnabled) Majority read concern is not enabled.
==============================================
pbm-agent --mongodb-uri="mongodb://XXX:XXX@testdb:27017/?authSource=admin&w=1&readConcernLevel=local"
2024-05-15T05:57:47.000+0000 I pbm-agent:
Version: 2.5.0
Platform: linux/amd64
GitCommit: be273eee454fbbb2bd269bb46c24078b35d98894
GitBranch: release-2.5.0
BuildTime: 2024-05-15_05:58_UTC
GoVersion: go1.22.3
2024-05-15T05:57:47.000+0000 I starting PITR routine
2024-05-15T05:57:47.000+0000 I node: rs1/testdb:27017
2024-05-15T05:57:47.000+0000 I listening for the commands
==============================================
Although I'd still NOT mention this particular option in release highlights as Mongo4.x is EOL. The main reason for implementing this change is to support scenarios when RS looses majority for some reason and customer still should have an ability to use PBM. Claim that PBM supports PSA topologies with readConcern majority disabled supposes that PBM supports PSMDB version lower that 5.0 and while we're still technically testing PBM with 4.4, I'm not sure that in PSMDB 4.2 + PBM 2.5.0 combination even basic functionality would work not mentioning new feature.
There was a problem hiding this comment.
@igroene @janwieremjewicz Are you OK with the updated wording?
nastena1606
force-pushed
the
PBM-1310-Release-notes-2.5.0
branch
3 times, most recently
from
f9d6ec2
to
e830820
Compare
nastena1606
force-pushed
the
PBM-1310-Release-notes-2.5.0
branch
from
e830820
to
9c30d76
Compare
Co-authored-by: Sandra Romanchenko <[email protected]>
…into PBM-1310-Release-notes-2.5.0
modified: docs/release-notes.md
new file: docs/release-notes/2.5.0.md
modified: mkdocs-base.yml
modified: variables.yml