Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebSocket support #182

Open
SemanticBeeng opened this issue Apr 10, 2019 · 2 comments
Open

WebSocket support #182

SemanticBeeng opened this issue Apr 10, 2019 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@SemanticBeeng
Copy link

SemanticBeeng commented Apr 10, 2019 •
edited
Loading

Would you consider porting this https://github.com/Spinoco/fs2-http/blob/series/0.4/src/main/scala/spinoco/fs2/http/websocket/WebSocket.scala.

The use of web socket s and FS2 gives a nice streaming semantics when http/2 is cannot be used.
@pepegar
Copy link
Owner

pepegar commented Apr 10, 2019

Currently I don't have a lot of time to put into OSS.

However, I'd be more than happy to help if you want to contribute the websockets module in hammock ;)

@pepegar pepegar added enhancement New feature or request help wanted Extra attention is needed labels Apr 10, 2019
@SemanticBeeng
Copy link
Author

Oki.
Just looking for a review to determine if it could fit or it conflicts with something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pepegar @SemanticBeeng