Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stellar overlay: Mandatory Flow control in bytes #549

Closed
pieterjan84 opened this issue Aug 13, 2024 · 3 comments
Closed

Stellar overlay: Mandatory Flow control in bytes #549

pieterjan84 opened this issue Aug 13, 2024 · 3 comments
Assignees

Comments

@pieterjan84
Copy link

FYI: stellar/stellar-core#4353

Flow control in bytes is now required. Also listed as breaking change in latest pre-release of stellar-core.

Implementation made for Stellarbeat: https://github.com/stellarbeat/js-stellar-node-connector/blob/master/src/connection/flow-controller.ts

If I'm mistaking that this is an issue for your project, please ignore :-)

@prayagd
Copy link
Collaborator

prayagd commented Aug 22, 2024

Thank you @pieterjan84 for raising the issue.

cc @pendulum-chain/devs is this relevant for us?

@b-yap
Copy link
Contributor

b-yap commented Aug 22, 2024

Yes it is an issue:

Error occurred during processing xdr message: ConfigError("Error{ code:ErrConf message:flow control bytes disabled }")

It appears when running the test (given the environment file and the json config files were setup):

RUST_LOG=info cargo run --example connect

Thank you once again @pieterjan84 !

@ebma
Copy link
Member

ebma commented Oct 2, 2024

This was fixed in #550 but we forgot to close it.

@ebma ebma closed this as completed Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants