Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detection Matching on languages not included in builder #26

Closed
EXPEpchaurasia opened this issue Feb 11, 2020 · 3 comments
Closed

Detection Matching on languages not included in builder #26

EXPEpchaurasia opened this issue Feb 11, 2020 · 3 comments

Comments

@EXPEpchaurasia
Copy link

Hi @pemistahl

I found this library recently and i want to thank you (first of all) for creating this. Its awesome and much better than what i've been using previously.

Found Issue :
I see that many times detectLanguageOf is detects a language that is not included when building the Detector.

e.g. text vegas returns the detected language as TAGALOG even though i didn't include this as one of the languages while building detector.
I am not sure if its a known issue. Or if i am doing something wrong while building the detector.

Anyways, i am will try to create a patch if i find the issue in code. Just wanted to get this known to you.

Thanks

@EXPEpchaurasia
Copy link
Author

I think i need to revisit this. closing this for now

@pemistahl
Copy link
Owner

Hi @EXPEpchaurasia, this sounds pretty much like issue #23 which I just solved a few days ago (or at least hoped to solve). Please try the most recent version 0.6.1 and check whether your problem still exists. If so, then provide a concrete example of what is going wrong. Thank you.

@EXPEpchaurasia
Copy link
Author

Sure, will try. Thanks @pemistahl for the prompt response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants