Skip to content
This repository has been archived by the owner on May 14, 2024. It is now read-only.

Adding Sunkenland #2724

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Adding Sunkenland #2724

wants to merge 4 commits into from

Conversation

engels74
Copy link
Contributor

@engels74 engels74 commented Feb 2, 2024 •
edited
Loading

Description

This PR adds a working egg for the game "Sunkenland". This solves #2720.

Notes regarding the server software

Their server software is very new. Released with the v0.2.0 update. It's still a bit weird to work with.

  • The Server Software can't generate a map on its own (yet?). Therefore a basic map created with the game itself, using the latest version as of this commit (v0.2.0), is included in the egg. The egg is configured to download the map, and put it into the /home/container/.wine/c_drive AppData folder.

  • There's no strict "server name" variable. It's tied to the World/Map Name. The install script is modified to rename the folder to whatever the users sets as SERVER_NAME.

  • The variable -makeSessionInvisible is bugged. No matter if you set it to true or false it'll set it to "true", making the game not show up in the Server List

  • The game has no default port(s) according to docs, but uses -port for Game Port and -publicport for Steam Query Port as far as I can tell. No documentation on it specifically, but it works and the server is connectable with those two commands.

Testing the egg

The egg in this PR is configured to use parkervcp's repository to download the world files required to launch the server. Therefore, the egg in this pull request will not function until it is merged.

If you wish to test the egg, you can use the one from my personal repository.
https://github.com/engels74/pterodactyl-eggs/blob/test-Sunkenland/game_eggs/steamcmd_servers/sunkenland/egg-sunkenland.json

Checklist for all submissions

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you tested and reviewed your changes with confidence that everything works?
  • Did you branch your changes and PR from that branch and not from your master branch?

New egg Submissions

  1. Does your submission pass tests (server is connectable)?
  2. Does your egg use a custom docker image?
    • Have you tried to use a generic image?
    • Did you PR the necessary changes to make it work?
  3. Have you added the egg to the main README.md and any other README files in subdirectories of the egg (e.g /game_eggs) according to the alphabetical order?
  4. Have you added a unique README.md for the egg you are adding according to the alphabetical order?
  5. You verify that the start command applied does not use a shell script
  6. The egg was exported from the panel

@engels74
Adding Sunkenland
6b3fa7e
@engels74
fixup: quick edit to the README.md
7cd7259 
Reminding the user to change the `WORLD_GUID`, if they end up uploading their own world to the server.
@engels74 engels74 mentioned this pull request Feb 2, 2024
Open
@QuintenQVD0 QuintenQVD0 self-assigned this Feb 2, 2024
@engels74
fixup: resolving issues
cdc59e1 
- mono was not needed
- winearch was not needed
- vcrun2019 -> vcrun2022
- added the `in:` for the region selection variable
- user now can't edit ports
- added `steam_disk_space` feature
@engels74
Copy link
Contributor Author

engels74 commented Feb 2, 2024

Resolved all the issues 👍 Also on the test branch

@QuintenQVD0 QuintenQVD0 linked an issue Feb 21, 2024 that may be closed by this pull request
[Egg Request]: Sunkenland #2720
Open
@engels74
fixup: updated world version
a0bbcb5 
- Updated the world version
- Made the world file "empty"
@engels74
Copy link
Contributor Author

engels74 commented Feb 22, 2024 •
edited
Loading

@QuintenQVD0 - Since you're the guy reviewing this 👍

  • I updated the World-file for the newest update as per this comment. The developers are saying that maps generated from v0.2.x should work in future versions as well.
  • I learned that you can use an "empty" world file, and the server software will "populate" the file after it has saved. I'm figuring this will work better for the egg, as the World should now be as random as possible for the user.

There's currently no option to choose when it saves, or how often.

@Liemander
Copy link

I'm trying to test this out and get the following error.
container@pterodactyl~ Error Event [35c22b75-9387-452a-be99-1f74a94468eb]: environment/docker: failed to run pre-boot process: environment/docker: failed to create container: Error response from daemon: No such image: ghcr.io/parkervcp/yolks:wine_latest

@QuintenQVD0
Copy link
Collaborator

I'm trying to test this out and get the following error. container@pterodactyl~ Error Event [35c22b75-9387-452a-be99-1f74a94468eb]: environment/docker: failed to run pre-boot process: environment/docker: failed to create container: Error response from daemon: No such image: ghcr.io/parkervcp/yolks:wine_latest

9/10 you are on arm64 what does not run wine.

@Liemander
Copy link

I'm trying to test this out and get the following error. container@pterodactyl~ Error Event [35c22b75-9387-452a-be99-1f74a94468eb]: environment/docker: failed to run pre-boot process: environment/docker: failed to create container: Error response from daemon: No such image: ghcr.io/parkervcp/yolks:wine_latest

9/10 you are on arm64 what does not run wine.

This is on my server that is on a 9900k.

@QuintenQVD0
Copy link
Collaborator

I'm trying to test this out and get the following error. container@pterodactyl~ Error Event [35c22b75-9387-452a-be99-1f74a94468eb]: environment/docker: failed to run pre-boot process: environment/docker: failed to create container: Error response from daemon: No such image: ghcr.io/parkervcp/yolks:wine_latest

9/10 you are on arm64 what does not run wine.

This is on my server that is on a 9900k.

then you have dns or docker issues as that image does exits.

@Liemander
Copy link

I'm trying to test this out and get the following error. container@pterodactyl~ Error Event [35c22b75-9387-452a-be99-1f74a94468eb]: environment/docker: failed to run pre-boot process: environment/docker: failed to create container: Error response from daemon: No such image: ghcr.io/parkervcp/yolks:wine_latest

9/10 you are on arm64 what does not run wine.

This is on my server that is on a 9900k.

then you have dns or docker issues as that image does exits.

I'm guessing its my dns. I'll dig down that rabbit hole. Thanks for the direction.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gOOvER gOOvER gOOvER requested changes

@QuintenQVD0 QuintenQVD0 Awaiting requested review from QuintenQVD0

At least 1 approving review is required to merge this pull request.

Assignees

@QuintenQVD0 QuintenQVD0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Egg Request]: Sunkenland
4 participants
@engels74 @Liemander @QuintenQVD0 @gOOvER