PostgreSQL Support #896
Draft
PostgreSQL Support #896
+3,107
−81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RMartinOscar
reviewed
Jan 8, 2025
database/migrations/2025_01_08_052636_add_driver_to_database_hosts copy.php
Outdated
Show resolved
Hide resolved
RMartinOscar
reviewed
Jan 8, 2025
Comment on lines
1
to
33
| <?php | ||
|
|
||
| use Illuminate\Database\Migrations\Migration; | ||
| use Illuminate\Support\Facades\Schema; | ||
|
|
||
| return new class extends Migration | ||
| { | ||
| /** | ||
| * Run the migrations. | ||
| */ | ||
| public function up(): void | ||
| { | ||
| switch (Schema::getConnection()->getDriverName()) { | ||
| case 'pgsql': | ||
| $database = DB::connection()->getDatabaseName(); | ||
| DB::statement(sprintf('REVOKE CONNECT ON DATABASE "%s" FROM public', $database)); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| /** | ||
| * Reverse the migrations. | ||
| */ | ||
| public function down(): void | ||
| { | ||
| switch (Schema::getConnection()->getDriverName()) { | ||
| case 'pgsql': | ||
| $database = DB::connection()->getDatabaseName(); | ||
| DB::statement(sprintf('GRANT CONNECT ON DATABASE "%s" TO public', $database)); | ||
| break; | ||
| } | ||
| } | ||
| }; |
There was a problem hiding this comment.
The user should do it not migrations
There was a problem hiding this comment.
Or should it be part of the installer?
There was a problem hiding this comment.
It should probably be documented somewhere then that it's important if your panel database is on the same server as the server one.
RMartinOscar
reviewed
Jan 8, 2025
database/migrations/2024_11_04_185326_revamp_api_keys_permissions.php
Outdated
Show resolved
Hide resolved
RMartinOscar
reviewed
Jan 8, 2025
| }); | ||
| break; | ||
| case 'pgsql': | ||
| DB::statement('ALTER TABLE egg_variables ALTER COLUMN rules TYPE jsonb USING to_jsonb(rules)'); |
There was a problem hiding this comment.
Unless absolute necessity you shouldn't use raw statements and what i see from other migrations tells me its not mandatory
RMartinOscar
reviewed
Jan 8, 2025
Comment on lines
31
to
38
| switch (Schema::getConnection()->getDriverName()) { | ||
| case 'mariadb': | ||
| case 'mysql': | ||
| $table->dropForeign('service_options_nest_id_foreign'); | ||
| break; | ||
| case 'sqlite': | ||
| $table->dropForeign(['nest_id']); | ||
| break; |
There was a problem hiding this comment.
Suggested change
| switch (Schema::getConnection()->getDriverName()) { | |
| case 'mariadb': | |
| case 'mysql': | |
| $table->dropForeign('service_options_nest_id_foreign'); | |
| break; | |
| case 'sqlite': | |
| $table->dropForeign(['nest_id']); | |
| break; | |
| $table->dropForeign(['nest_id']); |
Those are old format
RMartinOscar
reviewed
Jan 8, 2025
database/migrations/2021_03_21_104718_force_cron_month_field_to_have_value_if_missing.php
Outdated
Show resolved
Hide resolved
RMartinOscar
reviewed
Jan 8, 2025
database/migrations/2020_03_22_163911_merge_permissions_table_into_subusers.php
Outdated
Show resolved
Hide resolved
RMartinOscar
reviewed
Jan 8, 2025
database/migrations/2017_02_10_171858_UpdateAPIKeyColumnNames.php
Outdated
Show resolved
Hide resolved
RMartinOscar
reviewed
Jan 8, 2025
RMartinOscar
reviewed
Jan 8, 2025
database/migrations/2016_09_04_182835_create_notifications_table.php
Outdated
Show resolved
Hide resolved
RMartinOscar
reviewed
Jan 8, 2025
RMartinOscar
reviewed
Jan 8, 2025
RMartinOscar
reviewed
Jan 8, 2025
Comment on lines
+38
to
+49
| switch ($database->host->driver) { | ||
| case 'mysql': | ||
| case 'mariadb': | ||
| $database->dropUser($database->username, $database->remote); | ||
| $database->createUser($database->database, $database->username, $database->remote, $password, $database->max_connections); | ||
| $database->assignUserToDatabase($database->database, $database->username, $database->remote); | ||
| $database->flush(); | ||
| break; | ||
| case 'pgsql': | ||
| $database->updateUserPassword($database->database, $database->username, $database->remote, $password); | ||
| break; | ||
| } |
RMartinOscar
reviewed
Jan 8, 2025
| @@ -57,6 +64,7 @@ class DatabaseHost extends Model | |||
| 'password' => 'nullable|string', | |||
| 'node_ids' => 'nullable|array', | |||
| 'node_ids.*' => 'required|integer,exists:nodes,id', | |||
| 'driver' => 'required|string', | |||
There was a problem hiding this comment.
Suggested change
| 'driver' => 'required|string', | |
| 'driver' => 'required|string|in:' . self::DRIVERS, |
public const DRIVERS = 'mysql,mariadb,pgsql';
RMartinOscar
reviewed
Jan 8, 2025
| if ($driver === 'sqlite') { | ||
| return true; | ||
| } | ||
| switch ($driver) { |
RMartinOscar
reviewed
Jan 8, 2025
Comment on lines
+122
to
+132
| config()->set('database.connections._panel_install_test', [ | ||
| 'driver' => $driver, | ||
| 'host' => $host, | ||
| 'port' => $port, | ||
| 'database' => $database, | ||
| 'username' => $username, | ||
| 'password' => $password, | ||
| 'charset' => 'utf8mb4', | ||
| 'collation' => 'utf8mb4_unicode_ci', | ||
| 'strict' => true, | ||
| ]); |
There was a problem hiding this comment.
Use DynamicDatabaseConnection instead
There was a problem hiding this comment.
Is there a reason why DynamicDatabaseConnection doesn't just have a static set function?
RMartinOscar
reviewed
Jan 8, 2025
Comment on lines
+9
to
+25
| public const DB_DEFAULTS = [ | ||
| 'mysql' => [ | ||
| 'DB_CHARSET' => 'utf8', | ||
| 'DB_COLLATION' => 'utf8_unicode_ci', | ||
| 'DEFAULT_DB' => 'mysql', | ||
| ], | ||
| 'mariadb' => [ | ||
| 'DB_CHARSET' => 'utf8', | ||
| 'DB_COLLATION' => 'utf8_unicode_ci', | ||
| 'DEFAULT_DB' => 'mysql', | ||
| ], | ||
| 'pgsql' => [ | ||
| 'DB_CHARSET' => 'utf8', | ||
| 'DB_COLLATION' => 'en_US', | ||
| 'DEFAULT_DB' => 'postgres', | ||
| ], | ||
| ]; |
RMartinOscar
reviewed
Jan 8, 2025
RMartinOscar
requested changes
Jan 8, 2025
PseudoResonance
force-pushed
the
support-postgresql
branch
from
e8978b8 to
b8e343c
Compare
|
Sorry, I'm not comfortable with changing that many past migrations and adding switch statements to that many of them, especially from that many years back. Most likely what would have to happen is migration squashing to get it to work properly with Postgresql. Please see here: https://laravel.com/docs/11.x/migrations#squashing-migrations |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PostgreSQL as an alternative database option. Additionally, adds configurable driver option to the DynamicDatabaseConnection part.
The database driver type is saved in a new column
driverof the DatabaseHost, allowing for potentially other databases in the future if desired.I've tried to test everything I could think of, but please let me know if there's anything I missed, or if something should be adjusted. I want this to be as minimal of a maintenance burden as possible, but I do really want Postgres support because there's much better support for running it in a Kubernetes HA setup with CloudnativePG.