Various FRA improvements #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Paris from regions (should be classified only in locality) Add Street name with number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cité and Cités where missing in street types, I added them.
Paris is a complex city, it's known as region and locality but when we are searching for Paris, it should be only as a locality. That's why we should classified it only as locality.
Add Street name with number such as
Rue du 4 septembre.In fact there are a lot of streets named like dates eg
Rue du 8 Mai 1945Rue du 4 SeptembrePlace Du 11 Novembre 1945This PR doesn't classify all these streets, maybe we should add a special classification for full date.