feat(street_types): Add cité and cités to fra street types (#45)

Remove Paris from regions (should be classified only in locality) Add Street name with number
pelias · Jun 9, 2019 · 4aa9e3e · 4aa9e3e
1 parent 0ed71c5
commit 4aa9e3e
Show file tree

Hide file tree

Showing 4 changed files with 34 additions and 0 deletions.
diff --git a/classifier/scheme/street_name.js b/classifier/scheme/street_name.js
@@ -35,6 +35,24 @@ module.exports = [
       }
     ]
   },
+  {
+    // du 4 septembre
+    confidence: 0.5,
+    Class: StreetNameClassification,
+    scheme: [
+      {
+        is: ['StopWordClassification']
+      },
+      {
+        is: ['NumericClassification'],
+        not: ['PostcodeClassification']
+      },
+      {
+        is: ['AlphaClassification'],
+        not: ['StreetClassification', 'IntersectionClassification', 'LocalityClassification']
+      }
+    ]
+  },
   {
     // dos Fiéis de Deus
     confidence: 0.5,

diff --git a/resources/pelias/dictionaries/libpostal/fr/street_types.txt b/resources/pelias/dictionaries/libpostal/fr/street_types.txt
@@ -0,0 +1,2 @@
+cité|cite
+cités|cites
diff --git a/resources/pelias/dictionaries/whosonfirst/region/name:eng_x_preferred.txt b/resources/pelias/dictionaries/whosonfirst/region/name:eng_x_preferred.txt
@@ -0,0 +1,2 @@
+# This is not used as region
+!paris
diff --git a/test/address.fra.test.js b/test/address.fra.test.js
@@ -79,6 +79,18 @@ const testcase = (test, common) => {
   assert('Mery-Sur-Oise', [
     { locality: 'Mery-Sur-Oise' }
   ], true)
+
+  assert('4 Cité Du Cardinal Lemoine 75005 Paris', [
+    { housenumber: '4' }, { street: 'Cité Du Cardinal Lemoine' }, { postcode: '75005' }, { locality: 'Paris' }
+  ], true)
+
+  assert('32 Rue Du 4 Septembre', [
+    { housenumber: '32' }, { street: 'Rue Du 4 Septembre' }
+  ], true)
+
+  assert('12 Cité Roland Garros', [
+    { housenumber: '12' }, { street: 'Cité Roland Garros' }
+  ], true)
 }
 
 module.exports.all = (tape, common) => {