feat(place): support for places such as "Air & Space Museum" (#31)

pelias · May 28, 2019 · 3272908 · 3272908
1 parent 490e47d
commit 3272908
Show file tree

Hide file tree

Showing 3 changed files with 40 additions and 2 deletions.
diff --git a/classifier/scheme/place.js b/classifier/scheme/place.js
@@ -45,5 +45,24 @@ module.exports = [
         not: []
       }
     ]
+  },
+  {
+    // Air & Space Museum
+    confidence: 0.8,
+    Class: PlaceClassification,
+    scheme: [
+      {
+        is: ['AlphaClassification'],
+        not: ['StreetClassification', 'IntersectionClassification', 'StopWordClassification']
+      },
+      {
+        is: ['StopWordClassification'],
+        not: ['StreetClassification']
+      },
+      {
+        is: ['PlaceClassification'],
+        not: []
+      }
+    ]
   }
 ]
diff --git a/parser/AddressParser.js b/parser/AddressParser.js
@@ -64,8 +64,8 @@ class AddressParser extends Parser {
         new CompositeClassifier(require('../classifier/scheme/person')),
         new CompositeClassifier(require('../classifier/scheme/street_name')),
         new CompositeClassifier(require('../classifier/scheme/street')),
-        new CompositeClassifier(require('../classifier/scheme/intersection')),
-        new CompositeClassifier(require('../classifier/scheme/place'))
+        new CompositeClassifier(require('../classifier/scheme/place')),
+        new CompositeClassifier(require('../classifier/scheme/intersection'))
       ],
       // solvers
       [

diff --git a/test/venue.usa.test.js b/test/venue.usa.test.js
@@ -0,0 +1,19 @@
+const AddressParser = require('../parser/AddressParser')
+
+const testcase = (test, common) => {
+  let parser = new AddressParser()
+  let assert = common.assert.bind(null, test, parser)
+
+  assert('Air & Space Museum Washington DC', [
+    { place: 'Air & Space Museum' },
+    { locality: 'Washington' }, { region: 'DC' }
+  ], true)
+}
+
+module.exports.all = (tape, common) => {
+  function test (name, testFunction) {
+    return tape(`USA: ${name}`, testFunction)
+  }
+
+  testcase(test, common)
+}