additional addendum fields #529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joxit
approved these changes
May 7, 2020
|
Oh man, I must really want this feature, I did the PR twice! |
|
I cherry-picked the additional tests from the other PR |
|
closes #494 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
following on from #528 this PR uncomments the three fields I wanted to enable in the past but wasn't sure how much additional disk space would be required.
turns out that addendum fields don't add a lot of bytes.
I also took the liberty to modernize the codebase a bit and fix a test case that wasn't being run due to using a duplicate variable name.