Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New York City boroughs are indexed as locality records #99

Closed
7 tasks done
orangejulius opened this issue Jul 26, 2016 · 1 comment
Closed
7 tasks done

New York City boroughs are indexed as locality records #99

orangejulius opened this issue Jul 26, 2016 · 1 comment
Assignees
Labels

Comments

@orangejulius
Copy link
Member

orangejulius commented Jul 26, 2016

The 5 boroughs of NYC are categorised as PPLA2 records in Geonames. This feature code is not very specific, and includes large cities such as San Diego, which in general map to the locality type in Who's on First.

This causes issues with data correctness in general, and also breaks the labels after #93, which improves the labels in general, but works against us with this already incorrect data.

Right now, we are only able to set the layer of a Geonames record based on feature code, but it seems like we want to add the ability to special case individual records, starting with the 5 records below, and make them be a part of the borough layer.

NYC Boroughs and their Geonames IDs

  • Brooklyn 5110302
  • Manhattan 5125771
  • Queens 5133273
  • The Bronx 5110266
  • Staten Island 5139568

Stuff to do

  • Add borough to the list of geonames layers in API
  • Make sure there are tests for this (the layer mapping code already has a nice test suite)
@orangejulius
Copy link
Member Author

This was fixed in #100 and has acceptance tests as part of pelias/acceptance-tests#272. We still have to update the list of layers for Geonames in the API though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants