Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GID is incorrect on locality fields replaced by Geonames values #107

Closed
orangejulius opened this issue Aug 1, 2016 · 1 comment
Closed
Assignees

Comments

@orangejulius
Copy link
Member

orangejulius commented Aug 1, 2016

After #93, we now have much more consistent hierarchy data for Geonames records, but the GIDs are sometimes not correct. As can be seen in the query below, the ID section of the GID is correctly replaced with the Geonames ID, but the source section stays whosonfirst:

http://pelias.github.io/compare/#/v1/search%3Fsources=wof&text=mexico%20city
screenshot from 2016-08-01 12-41-34

The left column is production, without #93, the right is prod_build with #93. Note that the locality_gid field on the right is whosonfirst:locality:3530597: the id section has been updated to 3530597 to match the id of the record, but the source is still whosonfirst.

Update: this may be a bug in pelias/model and pelias/api: see this snippet of code from api

function makeNewId(placeType, id) {
  var doc = new Document('whosonfirst', placeType, id);
  return doc.getGid();
}
@orangejulius
Copy link
Member Author

Fixed in pelias/api#843!

@ghost ghost removed the Q1-2017 label Apr 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants