-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue with the unzip module #1
Comments
related: EvanOxfeld/node-unzip#52 |
I haven't seen this for ages, anyone else still experiencing this issue? |
related: EvanOxfeld/node-unzip#64 |
@hkrishna runs the import frequently (I think). Have you seen this error lately? |
No, I haven't seen this error as of 3 days ago when I imported allCountries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The module used to do a streaming unzip (called
unzip
innpm
) seems to crash with a fatal error when it finds an "invalid signature".At time of writing this prevented importing any more than 4,895,000 records from the 'allCountries.zip' file.
Ideally the library will just skip over erroneous records with an error provided via
stderr
.We can either patch the
unzip
module, or wait for thegeonames
data to be fixed.The text was updated successfully, but these errors were encountered: