Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with the unzip module #1

Closed
missinglink opened this issue May 9, 2014 · 5 comments
Closed

Issue with the unzip module #1

missinglink opened this issue May 9, 2014 · 5 comments

Comments

@missinglink
Copy link
Member

The module used to do a streaming unzip (called unzip in npm) seems to crash with a fatal error when it finds an "invalid signature".

At time of writing this prevented importing any more than 4,895,000 records from the 'allCountries.zip' file.

Ideally the library will just skip over erroneous records with an error provided via stderr.

We can either patch the unzip module, or wait for the geonames data to be fixed.

writing 1000 records to ES { written: 5160000, inserted: 4892000, queued: 268000 }
writing 1000 records to ES { written: 5161000, inserted: 4894000, queued: 267000 }
writing 1000 records to ES { written: 5162000, inserted: 4895000, queued: 267000 }

Error: invalid signature: 0xcb633d21
    at /var/www/pelias-geonames/node_modules/unzip/lib/parse.js:63:13
    at process._tickCallback (node.js:419:13)
@missinglink
Copy link
Member Author

related: EvanOxfeld/node-unzip#52

@missinglink
Copy link
Member Author

I haven't seen this for ages, anyone else still experiencing this issue?

@missinglink
Copy link
Member Author

related: EvanOxfeld/node-unzip#64

@sevko
Copy link
Contributor

sevko commented Jan 20, 2015

@hkrishna runs the import frequently (I think). Have you seen this error lately?

@hkrishna
Copy link
Contributor

No, I haven't seen this error as of 3 days ago when I imported allCountries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants