fix: send OPEN message when client reconnects #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are cases where the
openevent does not fire when callingpeer.reconnect()on the client.If the socket with the client is connected after the client information has been removed from the server, there is no issue.
However, if a new socket is connected due to a reconnect before the client information is removed from the server, the
MessageType.OPENis not sent, causing the client to fail in receiving theopenevent.Therefore, I modified it so that
MessageType.OPENis sent even when the client exists, when the_onSocketConnection()of the new socket is called.For reference, there is an issue posted in the PeerJS repo by someone who experienced the same problem as I did. peers/peerjs#1289