gouv.fr, co.uk, com.sg, other public suffixes are not being resolved as TLDs

[flotwig]

We're running in to an issue (cypress-io/cypress#3717) caused by an update to parse-domain causing public suffixes to not be resolved as TLDs. gouv.fr, co.uk, com.sg, and other public suffixes are not being resolved as TLDs ever since 2.1.0.

const parseDomain = require('parse-domain')

console.log(
  parseDomain('dev.classea12.beta.gouv.fr', {
    privateTlds: true,
    customTlds: /^[\d\.]+$/
  })
)

With [email protected], this results in:

{ tld: 'gouv.fr', domain: 'beta', subdomain: 'dev.classea12' }

With [email protected], this results in:

{ tld: 'fr', domain: 'gouv', subdomain: 'dev.classea12.beta' }

Potentially related: #64, #65

[jhnns]

Can you try out v2.1.8? Does it fix your issue?

[flotwig]

No, still the same issue. Tried 2.2.1 as well.

[jhnns]

Ok, I can confirm the issue. It's in combination with the privateTlds: true flag. I need to look into it.

[jhnns]

This fix shipped with v2.3.2 🚀