Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider loosening tests to not fail on presence of additional keys in API response #79

Open
tannerbaum opened this issue Mar 9, 2022 — with Microsoft Teams for GitHub · 2 comments
Open

Consider loosening tests to not fail on presence of additional keys in API response #79

tannerbaum opened this issue Mar 9, 2022 — with Microsoft Teams for GitHub · 2 comments

Comments

@tannerbaum Microsoft Teams for GitHub
Copy link
Contributor

Right now if Clockodo adds a new property to their response, some of our tests that are expecting properties to match one-to-one would fail. We should consider removing this check altogether, or allow for additional properties to be present.
@tannerbaum
Copy link
Contributor Author

Screen Shot 2022-03-09 at 14 24 05

@jhnns
Copy link
Member

jhnns commented Apr 7, 2022

Yep, that's not good. The test is testing too much :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jhnns @tannerbaum