feat(docz-core): add serve command #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthurdenner
commented
May 7, 2019
|
|
||
| export const serve = async (args: Arguments<any>) => { | ||
| const config = await parseConfig(args) | ||
| const dist = paths.getDist(config.dest) |
There was a problem hiding this comment.
I believe that cross-spawn handles relative paths well (that means I could have used config.dest directly, but I decided to take a more secure approach.
pedronauck
approved these changes
May 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi! 👋 This PR adds a new command,
docz serve, which builds the site usingdocz buildand then serves the output directory as a static site spawningserve.PS: I don't know why, but the visual output is not the same as when you run
servefrom the command line. I'll try to figure it out later, but it doesn't prevent the merge if everything works as expected.