fix(docz-theme-default): force codemirror to refresh (#637) #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swyxio
approved these changes
Feb 15, 2019
pedronauck
pushed a commit
that referenced
this pull request
Feb 19, 2019
pedronauck
added a commit
that referenced
this pull request
Feb 22, 2019
* dev: fix(docz-theme-default): fix duplicates in search (#532) (#639) fix(docz-theme-default): force codemirror to refresh (#637) (#638) added support for link to custom repository. (#595) v0.13.6 fix(docz-core): happypack plugin name fix(docz-core): default value for arguments chore: update dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug explanation
The selection in Playground code (CodeMirror) is not what you see.
So in some case you can't select some code.
And if you copy/paste it's not what you expected.
To Reproduce
examples/basicctrl+a)CodeMirror instance is not loaded correctly.
You can resize your window and it works (because CodeMirror refresh itself when window size change).
Solution
We force CodeMirror to refresh itself if its height have changed.
Screenshots