Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docz-core): turn off htmlMinifier when loading from templates #518

Merged
merged 1 commit into from
Dec 17, 2018
Merged

fix(docz-core): turn off htmlMinifier when loading from templates #518

merged 1 commit into from
Dec 17, 2018

Conversation

richardtks
Copy link
Contributor

Description

Fix #395
When running the NODE_ENV=production docz build, htmlMinifier was turned on to load the template file in docz-core, causing the jsx was minimized. For etc, <Theme /> become <Theme >. Eventually, resulting an error when passing to the prettier to be format.

Pre-merge checklist

  • Ensure NODE_ENV=production docz build ran successfully in all the examples
  • ran yarn run fix

Screenshots

Before
image
After
image

@pedronauck pedronauck merged commit bcf866a into doczjs:dev Dec 17, 2018
@pedronauck
Copy link
Member

Thanks @richardtks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants