fix(docz-theme-default): fix mobile menu peaking #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pedronauck
added a commit
that referenced
this pull request
Aug 29, 2018
* 'dev' of github.com:pedronauck/docz: fix(docz-theme-default): fix mobile menu peaking (#262)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
On mobile, the side menu is "peaking". Some elements are not hidden far enough. See the screenshot below.
Look to the far left. The caret icon and the dashed border are peaking from the menu.
Review
After the changes, I ran the basic example across the big 4 browsers to ensure fix consistency.
Screenshots