Skip to content

Commit

Permalink
fix(docz-core): remove https option and fix message (#321)
Browse files Browse the repository at this point in the history
  • Loading branch information
mpivaa authored and pedronauck committed Sep 10, 2018
1 parent 6ba0931 commit ea88841
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 7 deletions.
4 changes: 2 additions & 2 deletions packages/docz-core/src/bundlers/webpack/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ const uglify = new UglifyJs({
export const createConfig = (args: Args, env: Env) => async (
babelrc: BabelRC
): Promise<Configuration> => {
const { debug, host, port, protocol } = args
const { debug, host, port } = args

const config = new Config()
const isProd = env === 'production'
Expand Down Expand Up @@ -227,7 +227,7 @@ export const createConfig = (args: Args, env: Env) => async (
{
compilationSuccessInfo: {
messages: [
`Your application is running at ${protocol}://${hostname}:${port}`,
`Your application is running at http://${hostname}:${port}`,
],
},
},
Expand Down
5 changes: 0 additions & 5 deletions packages/docz-core/src/commands/args.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,6 @@ export interface Argv {
debug: boolean
typescript: boolean
propsParser: boolean
protocol: string
host: string
port: number
websocketPort: number
Expand Down Expand Up @@ -148,10 +147,6 @@ export const args = (env: Env) => (yargs: any) => {
type: 'boolean',
default: getEnv('docz.debug', false),
})
yargs.positional('protocol', {
type: 'string',
default: getEnv('docz.https', true) ? 'https' : 'http',
})
yargs.positional('host', {
type: 'string',
default: getEnv('docz.host', '127.0.0.1'),
Expand Down

1 comment on commit ea88841

@julioxavierr
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

Please sign in to comment.