Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support: Unexpected warning about the used NodeJS version #611

Closed
3 tasks done
nielsbasjes opened this issue Oct 13, 2022 · 10 comments · Fixed by #617 · May be fixed by #614
Closed
3 tasks done

support: Unexpected warning about the used NodeJS version #611

nielsbasjes opened this issue Oct 13, 2022 · 10 comments · Fixed by #617 · May be fixed by #614
Assignees
@peaceiris
Labels
enhancement New feature or request proposal Feature request resolved resolved issue

Comments

@nielsbasjes
Copy link

Checklist

  • I am using the latest version of this action.
  • I have read the latest README and followed the instructions.
  • I have read the latest GitHub Actions official documentation and learned the basic spec and concepts.

Describe your question

My job gives a warning

Node.js 12 actions are deprecated. 
For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. 
Please update the following actions to use Node.js 16: peaceiris/actions-hugo, peaceiris/actions-gh-pages

Relevant links

Public repository:
https://github.com/nielsbasjes/yauaa/blob/d1ee16088b5fe5a8142783097cc738d90f95f579/.github/workflows/website.yml

YAML config:
YAML workflow:


name: Documentation Website

on:
  push:
    branches:
      - main  # Set a branch to deploy
  pull_request:

jobs:
  deploy:
    runs-on: ubuntu-20.04
    steps:
      - uses: actions/checkout@v3
        with:
          submodules: true  # Fetch Hugo themes (true OR recursive)
          fetch-depth: 0    # Fetch all history for .GitInfo and .Lastmod

      - name: Setup Hugo
        uses: peaceiris/actions-hugo@v2
        with:
          hugo-version: 'latest'
          # extended: true

      - name: Build
        run: cd documentation && hugo --minify

      - name: Deploy
        uses: peaceiris/actions-gh-pages@v3
        if: github.ref == 'refs/heads/main'
        with:
          github_token: ${{ secrets.GITHUB_TOKEN }}
          publish_dir: ./documentation/public


### Relevant log output

This warning message is shown:


    Node.js 12 actions are deprecated. 
    For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. 
    Please update the following actions to use Node.js 16: peaceiris/actions-hugo, peaceiris/actions-gh-pages




### Additional context.

This workflow has run successfully for more than 8 months.
Apparently this is cause by a change in github:

https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/
@nielsbasjes nielsbasjes added the support User support label Oct 13, 2022
@peaceiris
Copy link
Owner

Thanks, I will release the next major version of this action with Nodo.js 16

@peaceiris peaceiris added enhancement New feature or request proposal Feature request and removed support User support labels Oct 13, 2022
@nielsbasjes
Copy link
Author

I expect this to be an issue for all github actions because I have also seen this in a different project (same warning about actions/checkout and actions/checkout):

Node.js 12 actions are deprecated. 
For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. 
Please update the following actions to use Node.js 16: actions/checkout, actions/checkout

soleo pushed a commit to soleo/actions-hugo that referenced this issue Oct 16, 2022
@soleo
Upgrade node from 12 to 16. Ref peaceiris#611
cbd0698
@soleo
Copy link

soleo commented Oct 16, 2022

@nielsbasjes Could I help out here? I am having the same issue with a few github actions with my own site as well.

@nielsbasjes
Copy link
Author

Other than the instructions on the page provided by Github I do not have additional information.

soleo pushed a commit to soleo/actions-hugo that referenced this issue Oct 17, 2022
@soleo
Upgrade node from 12 to 16. Ref peaceiris#611
a28e10e
@soleo
Copy link

soleo commented Oct 18, 2022

@nielsbasjes Do you wanna give soleo/[email protected] a try? I made the changes to upgrade to node16 recently and tried to use it for my own website.

@soleo soleo mentioned this issue Oct 18, 2022
Open
@soleo
Copy link

soleo commented Oct 18, 2022

@peaceiris Feel free to take a look to see if it make sense to you

@nielsbasjes
Copy link
Author

@nielsbasjes Do you wanna give soleo/[email protected] a try? I made the changes to upgrade to node16 recently and tried to use it for my own website.

For me it currently is only a warning.
So I'm just going to wait for the release and then let renovate update the version.

fortinetps added a commit to fortinetps/quartz that referenced this issue Oct 18, 2022
@fortinetps
workaround - peaceiris/actions-hugo#611
7f80036
@shenweiyan
Copy link

@peaceiris Feel free to take a look to see if it make sense to you

I got the same error, and try soleo/[email protected] , it failed with the same warning too.

@peaceiris
Copy link
Owner

I am planning the next major release from node12 to node16 this weekend.

@peaceiris peaceiris mentioned this issue Oct 23, 2022
Merged
peaceiris added a commit that referenced this issue Oct 23, 2022
@peaceiris
feat: bump node12 to node16 (#617)
9a77c64 
Close #611

- deps: bump node12 to node16
- deps: bump @actions/core from 1.6.0 to 1.10.0
@peaceiris peaceiris added the resolved resolved issue label Oct 24, 2022
@github-actions
Copy link

This issue has been LOCKED because of it being resolved!

The issue has been fixed and is therefore considered resolved.
If you still encounter this or it has changed, open a new issue instead of responding to solved ones.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@peaceiris peaceiris

Labels
enhancement New feature or request proposal Feature request resolved resolved issue
Projects
None yet
Milestone
No milestone
4 participants
@nielsbasjes @soleo @shenweiyan @peaceiris