Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An action actually ends in errors, but it shows that action is succeeded #362

Closed
yutopp opened this issue Jun 20, 2020 · 3 comments · Fixed by #363
Closed

An action actually ends in errors, but it shows that action is succeeded #362

yutopp opened this issue Jun 20, 2020 · 3 comments · Fixed by #363
Assignees
Labels
bug Something isn't working resolved resolved issue

Comments

@yutopp
Copy link
Contributor

yutopp commented Jun 20, 2020

Describe the bug

Although an action seems to be failed by an exception, it passed a CI steps in exit code 0. Maybe exceptions in the async functions are not handled in correctly.

To Reproduce

Set a wrong version of Hugo to hugo-version parameter. Please see YAML file section.

Expected behavior

Stop CI steps with error messages.

Screenshots

image

The step was succeeded with a green check, but actually it failed and stacktraces are printed.

Your YAML file

(I used this action in the private repo, thus I prepared a snippet)

      - name: Setup Hugo
        uses: peaceiris/actions-hugo@v2
        with:
          hugo-version: 'v0.72.0'

In this case, hugo-version is wrong (it should be '0.72.0'). Then the action will be failed with downloading a Hugo by HTTP 404.

Additional context

Add any other context about the problem here.

@yutopp yutopp added the bug Something isn't working label Jun 20, 2020
@yutopp yutopp changed the title sample_title An action actually ends in errors, but it shows that action is succeeded Jun 20, 2020
@peaceiris
Copy link
Owner

Thanks.

Duplicate of #310

@peaceiris
Copy link
Owner

Release actions-hugo v2.4.12 · peaceiris/actions-hugo has been released. Thank you for your contribution!
ʕ◔ϖ◔ʔ

@peaceiris peaceiris added the resolved resolved issue label Jun 25, 2021
@github-actions
Copy link

This issue has been LOCKED because of it being resolved!

The issue has been fixed and is therefore considered resolved.
If you still encounter this or it has changed, open a new issue instead of responding to solved ones.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working resolved resolved issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants