Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove _saved_python when purging venv #3137

Merged
merged 3 commits into from
Sep 1, 2024

Conversation

BVMiko
Copy link
Contributor

@BVMiko BVMiko commented Aug 31, 2024

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

The command pdm venv remove in-project --yes will remove the .pdm-python file if target of the python path is in the removed venv folder, but the pdm venv purge command does not. This updates the pdm venv purge command to match the behavior of the former.

Copy link

codecov bot commented Sep 1, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.67%. Comparing base (7cb963d) to head (2bb3d73).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/pdm/cli/commands/venv/purge.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3137      +/-   ##
==========================================
- Coverage   85.68%   85.67%   -0.02%     
==========================================
  Files         109      109              
  Lines       11037    11041       +4     
  Branches     2411     2412       +1     
==========================================
+ Hits         9457     9459       +2     
- Misses       1090     1091       +1     
- Partials      490      491       +1     
Flag Coverage Δ
unittests 85.47% <50.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit e80a81c into pdm-project:main Sep 1, 2024
22 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants