Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a bug reusing the python markers from the existing lock when appending result #3089

Merged
merged 2 commits into from
Aug 9, 2024

Conversation

frostming
Copy link
Collaborator

Signed-off-by: Frost Ming [email protected]

Pull Request Checklist

  • A news fragment is added in news/ describing what is new.
  • Test cases added for changed code.

Describe what you have changed in this PR.

Copy link

codecov bot commented Aug 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.67%. Comparing base (6950dba) to head (a6079ec).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3089      +/-   ##
==========================================
+ Coverage   85.64%   85.67%   +0.02%     
==========================================
  Files         109      109              
  Lines       10957    10958       +1     
  Branches     2393     2393              
==========================================
+ Hits         9384     9388       +4     
+ Misses       1086     1083       -3     
  Partials      487      487              
Flag Coverage Δ
unittests 85.47% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@frostming frostming merged commit 865fc62 into main Aug 9, 2024
24 checks passed
@frostming frostming deleted the fix/lock-merge branch August 9, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant