Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdm 2.5 breaks tox-pdm #1829

Closed
doloopuntil opened this issue Apr 9, 2023 · 1 comment · Fixed by j178/pdm#1
Closed

pdm 2.5 breaks tox-pdm #1829

doloopuntil opened this issue Apr 9, 2023 · 1 comment · Fixed by j178/pdm#1

Comments

@doloopuntil
Copy link

pdm>=2.5 has a new venv management feature, which introduced a breaking change in the semantics of the PDM_USE_VENV environment variable. Running tox with the tox-pdm plugin in a pdm-2.5 setup silently fails to synchronise the dependencies via tox-pdm, which under the hood complains with No virtualenv with key '1' is found, must be one of ['in-project'].

This is because in pdm<2.5 the variable PDM_USE_VENV was a boolean (1 meant using a venv), but in pdm>=2.5 it's the name of the virtual environment to use, so I think this line has to be changed to set PDM_USE_VENV=in-project.

@frostming
Copy link
Collaborator

Thanks, the override is not intentional, will be fixed in PDM

@frostming frostming transferred this issue from pdm-project/tox-pdm Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants