Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 2 should produce an error, not a DeprecationWarning #1590

Closed
1 task done
cmarqu opened this issue Dec 29, 2022 · 0 comments · Fixed by j178/pdm#1
Closed
1 task done

Python 2 should produce an error, not a DeprecationWarning #1590

cmarqu opened this issue Dec 29, 2022 · 0 comments · Fixed by j178/pdm#1
Labels
🐛 bug Something isn't working

Comments

@cmarqu
Copy link
Contributor

cmarqu commented Dec 29, 2022

  • I have searched the issue tracker and believe that this is not a duplicate.

The following code should probably now be an error instead of resulting in a DeprecationWarning:

pdm/src/pdm/project/core.py

Lines 153 to 157 in 780aa41

deprecation_warning(
"Python 2.7 has reached EOL and PDM will remove the support "
"in version 2.0. Please upgrade your Python to 3.6 or later.",
raise_since="2.0",
)

At the very least, the wording should be changed since PDM 2.0 is no longer in the future.

@cmarqu cmarqu added the 🐛 bug Something isn't working label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant