Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pdm does not issue warnings when attempting to install a dependency with the same name as your project #1466

Closed
baggiponte opened this issue Oct 26, 2022 · 0 comments · Fixed by j178/pdm#1
Labels
⭐ enhancement Improvements for existing features

Comments

@baggiponte
Copy link
Contributor

Is your feature request related to a problem? Please describe.

I was told today that If you name your project in the same way as a python dependency, you don't get any notification/warning about it. For example, I created a project with pdm and edited the pyproject.toml with name = 'requests' and version = '0.1.0', then I ran pdm add requests. this is the output:

Adding packages to default dependencies: requests
pdm.termui: ======== Start resolving requirements ========
pdm.termui:   requests
pdm.termui:   python>=3.10
pdm.termui:   Adding requirement requests
pdm.termui:   Adding requirement python>=3.10
pdm.termui: ======== Starting round 0 ========
pdm.termui: Pinning: python None
pdm.termui: ======== Ending round 0 ========
pdm.termui: ======== Starting round 1 ========
pdm.termui: Pinning: requests 0.1.0
pdm.termui: ======== Ending round 1 ========
pdm.termui: ======== Starting round 2 ========
pdm.termui: ======== Resolution Result ========
pdm.termui: Stable pins:
pdm.termui:     python None
pdm.termui:   requests 0.1.0
🔒 Lock successful
Changes are written to pdm.lock.
Changes are written to pyproject.toml.
All packages are synced to date, nothing to do.
Installing the project as an editable package...
pdm.termui: Removing distribution requests
pdm.termui: Preparing isolated env for PEP 517 build...
pdm.termui: Running PEP 517 backend to build a wheel for <Link file:///Users/lucabaggi/Documents/dev/pdm-test (from None)>
pdm.termui: Using pip 22.3 from /Users/lucabaggi/.local/share/pipx/shared/lib/python3.10/site-packages/pip (python 3.10)
pdm.termui: Collecting pdm-pep517>=1.0.0
pdm.termui:   Using cached pdm_pep517-1.0.5-py3-none-any.whl (305 kB)
pdm.termui: Installing collected packages: pdm-pep517
pdm.termui: Successfully installed pdm-pep517-1.0.5
pdm.termui: /var/folders/xw/p6xpq66x3hdcd0cl909cl_0m0000gn/T/pdm-build-env-3utgfmve-shared/lib/python3.10/site-packages/pdm/pep517/wheel.py:231: PDMWarning: No license files are matched with glob patterns ['LICENSES/*', 'LICEN[CS]E*', 'COPYING*', 'NOTICE*', 'AUTHORS*'].
pdm.termui:   for license_file in self.find_license_files():
pdm.termui:  - Adding requests.pth
pdm.termui:  - Adding requests-0.1.0.dist-info/WHEEL
pdm.termui:  - Adding requests-0.1.0.dist-info/METADATA
  ✔ Update requests 0.1.0 -> 0.1.0 successful

🎉 All complete!

Describe the solution you'd like

Perhaps an interactive prompt pops up asking for confirmation? I am willing to do that, of course.

@baggiponte baggiponte added the ⭐ enhancement Improvements for existing features label Oct 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⭐ enhancement Improvements for existing features
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant