Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import of github.com/prometheus/log is deprecated and breaks dep in projects that already use logrus #13

Closed
mattb opened this issue Oct 19, 2017 · 1 comment

Comments

@mattb
Copy link

mattb commented Oct 19, 2017

https://github.com/prometheus/log is deprecated and currently redirects to https://github.com/prometheus-junkyard/log but this package is imported by subscription_provider.go:

https://github.com/pdf/golifx/blob/master/common/subscription_provider.go#L6

Because of an issue with logrus - sirupsen/logrus#451 - this causes dependency problems with projects that already import logrus. Due to the deprecation of prometheus/log it looks like that project won't fix it. It looks like github.com/prometheus/common/log is the correct import now.

@pdf
Copy link
Owner

pdf commented Oct 19, 2017

That should absolutely not be imported there, looks like goimports screwed me (due to fat fingers).

@pdf pdf closed this as completed in 6bf6c7b Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants