Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added stats to compaction #2

Merged
merged 1 commit into from
Jan 9, 2018
Merged

Added stats to compaction #2

merged 1 commit into from
Jan 9, 2018

Conversation

fulgas
Copy link

@fulgas fulgas commented Jan 8, 2018 •
edited
Loading

  • Add stats to compaction,
  • Updated benchmark

@pcmind
Copy link
Owner

pcmind commented Jan 8, 2018 •
edited
Loading

Please resolve issues and merge conflicts.
I would also be more useful to receive Env by constructor parameter.

pcmind
pcmind reviewed Jan 9, 2018
View reviewed changes
leveldb-api/src/main/java/org/iq80/leveldb/Env.java Outdated
{
static long nowMicros()
{
return TimeUnit.MILLISECONDS.convert(System.currentTimeMillis(), TimeUnit.MICROSECONDS);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using System#currentTimeMillis() to count micro seconds will not return the expected result.
Use System.nanoTime() instead.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True...

@pcmind pcmind merged commit 09e0c6c into pcmind:master Jan 9, 2018
wdroste added a commit to brinqa/leveldb that referenced this pull request Nov 18, 2022
@wdroste
Merged in BRINQA-14623 (pull request pcmind#2)
a428311 
BRINQA-14623 -Compression code had a leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pcmind pcmind pcmind left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fulgas @pcmind