Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resource dependency cycles #50

Closed
TheMeier opened this issue Mar 8, 2019 · 3 comments
Closed

resource dependency cycles #50

TheMeier opened this issue Mar 8, 2019 · 3 comments

Comments

@TheMeier
Copy link
Contributor

TheMeier commented Mar 8, 2019

This https://github.com/pcfens/puppet-ca_cert/blob/9b4eb980c8c4419d629d0d0e5c95097624d84344/manifests/init.pp#L58 creates dependency cycles. I guess Class['::ca_cert'] -> should be Package[$package_name] instead.

Also it would be better to move it to the already existing conditional block starting at line 76
@TheMeier TheMeier changed the title Dependency cylcles resource dependency cycles Mar 8, 2019
@pcfens pcfens closed this as completed in 4495f40 Mar 8, 2019
@pcfens
Copy link
Contributor

pcfens commented Mar 8, 2019

Thanks for helping catch this. Can you verify that 4495f40 fixes it?

I'll plan on pushing a new release too, but I'll wait a bit in case that didn't fix it.

@TheMeier
Copy link
Contributor Author

TheMeier commented Mar 8, 2019

@pcfens lit me quickly add a test for it.

@TheMeier TheMeier mentioned this issue Mar 8, 2019
Merged
@TheMeier
Copy link
Contributor Author

TheMeier commented Mar 8, 2019

Also the travis test seem to be failing for some time. How about converting this module to pdk?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pcfens @TheMeier