Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: apply the new filter from pcdsutils #127

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

ZLLentz
Copy link
Member

@ZLLentz ZLLentz commented Oct 13, 2023

Ignore (demote) one specific pydm at-exit error log, and opt in to future extensions to that demoter.

In the pcds-5.8.0 environment, enough qt details have changed that we now get a bunch of spammy error messages at application close. I've yet to be able to figure out a fix for this, so I think a prudent approach is to filter the log messages from ERROR to DEBUG.

This is a companion to pcdshub/pcdsutils#81

@ZLLentz
Copy link
Member Author

ZLLentz commented Oct 17, 2023

The referenced PR is now in a tag, so hopefully the CI runs here today

@ZLLentz ZLLentz marked this pull request as ready for review October 17, 2023 17:12
@ZLLentz ZLLentz requested review from klauer and tangkong October 17, 2023 17:13
Copy link
Contributor

@tangkong tangkong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ZLLentz ZLLentz merged commit bbe0036 into pcdshub:master Oct 17, 2023
9 checks passed
@ZLLentz ZLLentz deleted the enh_pydm_filter branch October 17, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants