Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add highlightjs to dependencies #54

Closed
asnowwolf opened this issue Dec 3, 2015 · 2 comments
Closed

Add highlightjs to dependencies #54

asnowwolf opened this issue Dec 3, 2015 · 2 comments

Comments

@asnowwolf
Copy link

This package is dependent on highlightjs but not in bower.json's "dependencies" field.

@pc035860
Copy link
Owner

Hi @asnowwolf ,

Though the highlightjs dependency is actually removed in #28 , it seems so many people asking about this.
So I guess I'll just add it back this weekend. Thanks for the opinion.

@pc035860
Copy link
Owner

pc035860 commented Jan 3, 2016

Well, I changed my mind after checking out on the bower package's github repo.

It has one huge packed highlight.js with all languages included, and usually you'll only use one or two of them. This adds so much overhead to the network transfer and javascript parsing.

Size difference:

So I recommend that you just stay with the suggested way to include highlight.js described in README.

There's currently no official bower package of highlight.js (see here). You should either build highlight.js yourself or use the pre-built one on cdnjs.

Closing the issue.

@pc035860 pc035860 closed this as completed Jan 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants