Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numpy and Scipy deprecation warnings fixed #63

Merged
merged 2 commits into from
Nov 10, 2022

Conversation

fjosw
Copy link
Contributor

@fjosw fjosw commented Oct 5, 2022

This PR fixes two deprecation warnings.

the machar attribute is deprecated since numpy 1.22
@fjosw
Copy link
Contributor Author

fjosw commented Oct 5, 2022

The Numpy deprecation was also addressed in #59 but I think using tiny instead of smallest_normal should be backward compatible.

@fjosw
Copy link
Contributor Author

fjosw commented Oct 6, 2022

Looks like all tests but PYTHON_VERSION=3.6, MINICONDA=C:\Miniconda36-x64, PYTHON_ARCH=64 succeeded. That one exits with

error: Setup script exited with 
Beginning with Matplotlib 3.6, Python 3.8 or above is required.
You are using Python 3.6.5.
This may be due to an out of date pip.
Make sure you have pip >= 9.0.1.

which seems to be unrelated to my changes. I guess this is related to #62 and python 3.6 end of life?

@pbrod pbrod merged commit aa2e256 into pbrod:master Nov 10, 2022
@pbrod
Copy link
Owner

pbrod commented Nov 10, 2022

Thanks @fjosw for the effort of making this pullrequest.

@fjosw fjosw deleted the feat/numpy_deprecation branch November 10, 2022 12:19
@fjosw
Copy link
Contributor Author

fjosw commented Nov 10, 2022

My pleasure! Could you maybe release a new version on pypi such that dependencies profit from the changes?

@pbrod
Copy link
Owner

pbrod commented Nov 10, 2022

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants