Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix numpy deprecation warning on machar.tiny #59

Closed
wants to merge 1 commit into from

Conversation

peendebak
Copy link

The line _TINY = np.finfo(float).machar.tiny from numdifftools/multicomplex.py has been deprecated by numpy

@pbrod

@peendebak
Copy link
Author

@pbrod Tests are failing because of the numpy versions available on older python versions. I can build a check (e.g. if numpy version >= 1.22, use smallest_normal, otherwise use machar.tiny), but perhaps you want to update version requirements on python and numpy as well.

@pbrod
Copy link
Owner

pbrod commented Nov 10, 2022

@peendebak please build a check for if numpy version >= 1.22, use smallest_normal, otherwise use machar.tiny

@pbrod
Copy link
Owner

pbrod commented Nov 10, 2022

Fixed in commit 912bacc

@pbrod pbrod closed this Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants