Feature/pp 68940 #222
Feature/pp 68940 #222
Conversation
|
Code Climate has analyzed commit d4b3d9b and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 80.0% (5% is the threshold). This pull request will bring the total coverage in the repository to 84.0% (-0.4% change). View more on Code Climate. |
Black Duck Security ReportMerging #222 into master will not change security risk. Added ComponentsClean: 1 Removed ComponentsClean: 1 |
|
Kudos, SonarCloud Quality Gate passed!
|
| @@ -15,28 +15,30 @@ export interface HttpsClientMessage { | |||
| class PayPayRestSDK { | |||
| private options: any = ""; | |||
| private productionMode: boolean = false; | |||
| private perfMode: boolean = false; | |||
There was a problem hiding this comment.
Why do you keep instance variables?
There was a problem hiding this comment.
@tilfin we are refactoring the whole SDK (repeating config files etc), we will be pushing that feature branch in a day or two please feel free to contribute on that draft PR.
| this.auth.setAuth(clientConfig.clientId, clientConfig.clientSecret, clientConfig.merchantId); | ||
| if (clientConfig.productionMode) { | ||
| this.productionMode = clientConfig.productionMode | ||
| } else { | ||
| this.productionMode = false; | ||
| } | ||
| this.config = new Conf(this.productionMode); | ||
| if (clientConfig.perfMode) { |
There was a problem hiding this comment.
Optional boolean variables should be compared with undefined to determine if those are applied.
There was a problem hiding this comment.
@tilfin we are refactoring the whole SDK (repeating config files etc), we will be pushing that feature branch in a day or two please feel free to contribute on that draft PR.
All Submissions:
New Feature Submissions:
Changes to Core Features: