#711 proposal for better error messages.. #728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
End users might be confused, but this should help us a bit if we have to triage.
anilgursel
reviewed
Aug 9, 2019
| case Failure(t) => logger.error(s"Failed to start the listener $listenerName.", t) | ||
| case Success(StartFailure(t)) => logger.error(s"Failed to start the listener $listenerName.", t) | ||
| case Failure(t) if (t.isInstanceOf[TimeoutException]) => | ||
| logger.error(s"The Unicomplex could not start the listener, $listenerName, within $to.", t) |
There was a problem hiding this comment.
is it guaranteed that TimeoutException would be thrown only after to? Some other component may timeout on some other operation and could potentially send TimeoutException back to Unicomplex?
There was a problem hiding this comment.
That is the problem I'm trying to deal with. That is happening a lot and the error message makes it confusing what's happening. If some other operation times out, that should come back in Success(StartFailure(t)) case and you will see that in the stack trace.
There was a problem hiding this comment.
So in your case what that user would see is:
The Unicomplex reported a start failure for the listener, foo listener. {TimeoutException.stacktrace}
There was a problem hiding this comment.
@akara Any opinion on this?
And I hope all is well!
anilgursel
approved these changes
Aug 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fix we have on master for 711 has error messages that make it hard to triage. This addresses that.