Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: performance benchmarking #647

Draft
wants to merge 30 commits into
base: develop
Choose a base branch
from
Draft

feat: performance benchmarking #647

wants to merge 30 commits into from

Conversation

grablack
Copy link
Contributor

Outputs consumable report detailing all metrics

@grablack grablack marked this pull request as ready for review October 25, 2021 18:53
@grablack grablack requested a review from paypal-are November 29, 2021 15:05
paypal-are
paypal-are reviewed Dec 16, 2021
View reviewed changes
tools/performance/lighthouse.js Outdated
`<tr>
<td>${score}</td>
<td>${desktopAverageScores[score].performance.toFixed(3)}</td>
<td>${desktopAverageScores[score].accessibility.toFixed(3)}</td>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Throughout the module we have virtually identical functions for desktopAverageScores and mobileLighthouseScore, could we abstract these transformations to accept an arbitrary score and remove this duplication?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made an update here

@grablack grablack added the DO NOT MERGE Requires a change from some external dependency or service label Mar 8, 2022
@Seavenly Seavenly marked this pull request as draft October 19, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paypal-are paypal-are paypal-are approved these changes

Assignees
No one assigned
Labels
approved DO NOT MERGE Requires a change from some external dependency or service testing complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@grablack @paypal-are