Convert Delegation Pattern to Completion Handler #293
Conversation
| if let error { | ||
| self.setUpdateSetupTokenFailureResult(vaultError: error) | ||
| } else if let result { | ||
| self.approveResultSuccessResult( |
There was a problem hiding this comment.
qq: should this method be named approveOrderSuccessResult()?
There was a problem hiding this comment.
That's a good call. There are many changes I want to make on the demo app, but I stuck to ones relevant to the conversion.
Like needing the loading progressView where I forgot them, to see if there were delays introduced in PayPal vault.
|
I do see how completion handlers could be useful though. We do have some time in the beta to figure out the best strategy. Ultimately offering both sounds like a viable option to me. |
|
| await paypalVaultViewModel.vault(setupTokenID: setupTokenID) | ||
| ZStack { | ||
| Button("Vault PayPal") { | ||
| Task { |
There was a problem hiding this comment.
random q: would it be cleaner if we created the Task within the paypalVaultViewModel.vault() method?
There was a problem hiding this comment.
Button actions are synchronous contexts, so I need to create a Task block there to call an async/await function.
There was a problem hiding this comment.
It makes sense what you are saying, make the views look cleaner. Let me add that to demo app refactor ticket.
CHANGELOG.md
Outdated
| * Remove `vault(vaultRequest:)` method that uses delegate callbacks | ||
| * Add `approveOrder(request:completion:(CardResult?, Error?) -> Void)` to `CardClient` | ||
| * Add `vault(request:completion:(CardVaultResult?, Error?) -> Void)` to `CardClient` | ||
| * Add `approveOrder(request:) async throws -> Cardresult` |
There was a problem hiding this comment.
| * Add `approveOrder(request:) async throws -> Cardresult` | |
| * Add `approveOrder(request:) async throws -> CardResult` |
There was a problem hiding this comment.
Thank you! Nice catch!
* Remove MXO (#291) * Remove MXO * remove Package.resolved file containing incompatible pinstorage version * CHANGELOG entry * Jax feedback and docStrings correction * Remove PatchOrder for MXO, unused files in demo app * Remove more classes used exclusively for MXO * Convert Delegation Pattern to Completion Handler (#293) * PayPal remove delgation pattern for completion handler function for checkout * lint error for paypal start * completion and analytics into notify functions * paypal vault completion, unit tests * remove PayPal delegates, references * Card vault to completion, unit tests * Card approve to completion, unit tests * docstrings for approve completion param * wrap paypal functions in async await * async await wrapper for CardClient functions * remove CardDelegate and references * fix error in notifyCheckoutFailure * Make error names and messages payPal caps consistent * changelog entires * Steven PR feedback: typo in Chagelog * Simplify Cancel Errors (#296) * Simplify cancel errors * CHANGELOG for the cancel errors * Steven PR feedback: change back CardClientError.canceled to .threeDSecureCanceled * CHANGELOG update * Cancel error handling (#297) * http performRequest returns NetworkingClientErrors * CardClient helper function for threeDSCancel, demo app cancel, demo app minor fixes * PayPalClient cancel helper functions and demo app changes * Steven PR feedback: move static helper functions to error enums * Rename CardClientError -> CardError, PayPalWebCheckoutError -> PayPalError * Steven PR feedback: return CoreSDKError in merchant completion handler * CHANGELOG and analytics typo and fix wrong code in graphql error * v2 migration guide (#295) * v2 migration guide * just cocoapods or SPM * fix typos * minor spacing changes * Update with simplified cancel errors * Steven PR feedback - diff to render green/red * include removal of delegate methods in delete block * update with cardClient threeDSecureCanceled error * change to threeDSecureCanceled in migration steps * add comment highlighting cancellation errors * typo fix * clarify separating cancel cases in errors * revert cancel handling instructions * add changes for cancellation helper methods * fix typo in PayPalError.isCheckoutCanceled * Steven PR feedback * Make PayPalError and CardError Code enum consistent (#298) * Changelog: move additive changes from breaking section (#299) * Changelog: move additive changes from breaking section * remove duplicate line for PayPal cancel errors
Summary of changes
Checklist
Authors