Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump dep version for "github.com/prometheus/common" #39

Closed
Huang-Wei opened this issue Nov 1, 2021 · 2 comments · Fixed by #40
Closed

Bump dep version for "github.com/prometheus/common" #39

Huang-Wei opened this issue Nov 1, 2021 · 2 comments · Fixed by #40
Labels
enhancement New feature or request
Milestone
v0.2.1

Comments

@Huang-Wei
Copy link
Contributor

Huang-Wei commented Nov 1, 2021 •
edited
Loading

The code below

load-watcher/pkg/watcher/internal/metricsprovider/prometheus.go

Line 66 in 1c92ae3

RoundTripper: config.NewBearerAuthRoundTripper(config.Secret(opts.AuthToken), api.DefaultRoundTripper),

is no longer valid in the latest Prometheus library.

The code should be refactored to:

config.NewAuthorizationCredentialsRoundTripper("Bearer", token, rt)

This is found when I wanted to bump the version of scheduler-plugins to k8s 1.22.
@zorro786
Copy link
Contributor

zorro786 commented Nov 1, 2021

@wangchen615 Could you please look into upgrading Prometheus library to v0.26.0 from v0.15.0?

@zorro786 zorro786 added the enhancement New feature or request label Nov 1, 2021
@zorro786 zorro786 added this to the v0.2.1 milestone Nov 1, 2021
@Huang-Wei Huang-Wei mentioned this issue Nov 1, 2021
Merged
@Huang-Wei
Copy link
Contributor Author

@zorro786 I just raised a PR :)

This was referenced Nov 2, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.2.1
Development

Successfully merging a pull request may close this issue.

Use latest prometheus lib to construct roundtripper Huang-Wei/load-watcher
2 participants
@Huang-Wei @zorro786