Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add benchmark test for SuggestionsEngine.reloadSuggestions #311

Open
pjeli opened this issue Apr 8, 2022 · 1 comment
Open

Add benchmark test for SuggestionsEngine.reloadSuggestions #311

pjeli opened this issue Apr 8, 2022 · 1 comment
Labels
good first issue Good for newcomers tests Tests need to be changed or added

Comments

@pjeli
Copy link
Collaborator

pjeli commented Apr 8, 2022

It occurred to me that the testing I did with AirConcurrentMap could have been better validated if I had had a benchmark test against the SuggestionEngine.

This is relatively straightforward to do and folks can use the existing BenchmarkGSetFiltering code with minimal changes to achieve this. I'll leave this up if anyone wants to tackle it or else I'll do it myself.
@pjeli pjeli added good first issue Good for newcomers tests Tests need to be changed or added labels Apr 8, 2022
@pjeli pjeli mentioned this issue Apr 8, 2022
Closed
@pjeli
Copy link
Collaborator Author

pjeli commented Apr 11, 2022 •
edited
Loading

Unfortunately due to the failure of #312 I don't really feel motivated to bother with implementing this right now. Will keep this open incase any other optimization ideas pop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers tests Tests need to be changed or added
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjeli