Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display payjoin errors within the UI #50

Closed
nickfarrow opened this issue Nov 6, 2022 · 4 comments
Closed

Display payjoin errors within the UI #50

nickfarrow opened this issue Nov 6, 2022 · 4 comments

Comments

@nickfarrow
Copy link
Collaborator

It would be great for UX and testing if we could see errors within the UI.

Usually this would not be so important for testing, since you can just read the logs. However fetching the logs on umbrel is very slow and makes for a bad experience when payjoins are failing.

A user should be able to know immediately if a node rejected a channel for , e.g. too small.

@DanGould
Copy link
Contributor

DanGould commented Nov 9, 2022

I think it makes the most sense to keep the errors via Push API (Service Workers), but that requires https so I'm not sure it's going to work in the umbrel environment. Without a service worker, if an error propagates while you're not looking at the web page you're going to miss it unless it's stored on the server until requested.

@0xBEEFCAF3
Copy link
Contributor

Can we use web sockets or worse-case polling? The first thing the webapp does is acquire pj state.

@DanGould
Copy link
Contributor

DanGould commented Nov 9, 2022

payjoin receiver errors are sent back to the sender which is done now in #57.

to show them in the receiver it sounds like Armin's on the right track

@DanGould
Copy link
Contributor

closed by #93

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants